Adding Improve DC Noise Rejection example in NI-DMM by divakar-selvam07 · Pull Request #2217 · ni/nimi-python

divakar-selvam07 · 2026-10-08T10:55:21Z

This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.
~~I've added tests applicable for this pull request~~

What does this Pull Request accomplish?

Adds nidmm_improve_dc_noise_rejection.py, a Python adaptation of the LabVIEW “Improve DC Noise Rejection” example.
Updates CHANGELOG.md to call out the new examples in the unreleased section.

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

Manually validated with a simulated instrument and an actual hardware instrument.

…into users/diva/add-nidmm-improve-dc-noise-rejection-example

codecov-commenter · 2026-10-08T10:59:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.49%. Comparing base (cdbd8f2) to head (c8757ec).

❗ There is a different number of reports uploaded between BASE (cdbd8f2) and HEAD (c8757ec). Click for more details.

HEAD has 78 uploads less than BASE

Flag BASE (cdbd8f2) HEAD (c8757ec)

nifakeunittests 15 5

nidcpowerunittests 15 5

nidigitalunittests 15 5

nimodinstunittests 15 5

nirfsaunittests 15 5

niscopeunittests 15 5

nitclkunittests 15 5

codegenunittests 3 1

nidigitalsystemtests 1 0

nifgensystemtests 1 0

nirfsasystemtests 1 0

nirfsgsystemtests 1 0

nidcpowersystemtests 1 0

nitclksystemtests 1 0

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2217      +/-   ##
==========================================
- Coverage   88.11%   81.49%   -6.63%     
==========================================
  Files          88       63      -25     
  Lines       22832    12115   -10717     
==========================================
- Hits        20119     9873   -10246     
+ Misses       2713     2242     -471

Flag	Coverage Δ
codegenunittests	`84.78% <ø> (ø)`
nidcpowersystemtests	`?`
nidcpowerunittests	`89.53% <ø> (ø)`
nidigitalsystemtests	`?`
nidigitalunittests	`68.43% <ø> (ø)`
nidmmsystemtests	`92.33% <ø> (ø)`
nifakeunittests	`86.08% <ø> (ø)`
nifgensystemtests	`?`
nimodinstsystemtests	`73.85% <ø> (ø)`
nimodinstunittests	`94.20% <ø> (ø)`
nirfsasystemtests	`?`
nirfsaunittests	`63.40% <ø> (ø)`
nirfsgsystemtests	`?`
niscopesystemtests	`89.99% <ø> (ø)`
niscopeunittests	`43.20% <ø> (ø)`
nisesystemtests	`91.50% <ø> (ø)`
niswitchsystemtests	`81.66% <ø> (ø)`
nitclksystemtests	`?`
nitclkunittests	`98.26% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…dmm-improve-dc-noise-rejection-example # Conflicts: # docs/nidmm/examples.rst

divakar-selvam07 · 2026-10-09T11:17:40Z

This PR is ready for @Avinash2Suresh 's review.

divakar-selvam07 · 2026-10-09T12:16:53Z

@jarnoldNI , the PR is ready for your review.

ni-jfitzger · 2026-10-12T21:48:35Z

If we're going to copy the example, should we adapt the example description, too?
"""
By varying the weighting of the samples that compose a single measurement, noise can be removed from the measurement. The DC Noise Rejection attribute controls the sample weighting. The signal frequencies removed from the measurement are related to the aperture time selected.
"""

@marcoskirsch What do you think?

jarnoldNI · 2026-10-14T14:57:02Z

If we're going to copy the example, should we adapt the example description, too? """ By varying the weighting of the samples that compose a single measurement, noise can be removed from the measurement. The DC Noise Rejection attribute controls the sample weighting. The signal frequencies removed from the measurement are related to the aperture time selected. """

@marcoskirsch What do you think?

@ni-jfitzger @marcoskirsch - I like the idea of adding a description like this to the examples. If we do it for this one, we should do it for all of the ones we're working on.

ni-jfitzger · 2026-10-14T16:34:49Z

+        # For aperture times over 100 ms, enable AutoZero to compensate for drift.
+        # The DMM takes shorter measurements, applies a new AutoZero offset to each,
+        # averages them, and returns one value.


We're setting auto_zero, way up above. Does this comment need to be split?
Or maybe we set auto_zero down here?

Maybe I'm nitpicking, but I feel like this comment could also be clearer. The property that gets set is auto_zero. AutoZero is the enum and it's not like we have a feature with that spelling. The user manual page title it "Auto Zero".
https://www.ni.com/docs/en-US/bundle/ni-dmm/page/auto-zero.html

@marcoskirsch Do you have any thoughts on this?

@ni-jfitzger That makes sense. I’ve split the comment, placed the Auto Zero explanation beside auto_zero, and kept the averaging explanation beside number_of_averages. I’ve also corrected the spelling to “Auto Zero.”

…' of https://github.com/NI-velmurugan/nimi-python into users/diva/add-nidmm-improve-dc-noise-rejection-example

NI-velmurugan and others added 4 commits October 7, 2026 19:45

Add @Avinash2Suresh as a code owner

4eb8624

add: add Improve DC Noise Rejection example for nidmm

cdf7fa8

Remove @Avinash2Suresh from CODEOWNERS

c965114

Merge branch 'master' of https://github.com/NI-velmurugan/nimi-python …

9d4d325

…into users/diva/add-nidmm-improve-dc-noise-rejection-example

divakar-selvam07 added 3 commits October 8, 2026 16:45

fix: fix tests

b12451d

Trigger CI build

944eda7

Merge remote-tracking branch 'upstream/master' into users/diva/add-ni…

8173be4

…dmm-improve-dc-noise-rejection-example # Conflicts: # docs/nidmm/examples.rst

Avinash2Suresh suggested changes Oct 9, 2026

View reviewed changes

resolve PR comments

f97bec3

divakar-selvam07 requested a review from Avinash2Suresh October 9, 2026 12:09

Avinash2Suresh approved these changes Oct 9, 2026

View reviewed changes

divakar-selvam07 added 3 commits October 9, 2026 18:06

Trigger CI build

eeb4882

Trigger CI build

5b30a87

Trigger CI build

a39ffd0

jarnoldNI reviewed Oct 9, 2026

View reviewed changes

Comment thread src/nidmm/examples/nidmm_improve_dc_noise_rejection.py

add: add number of averages parameter

5c9e94f

divakar-selvam07 requested review from Avinash2Suresh and jarnoldNI October 12, 2026 06:03

Avinash2Suresh approved these changes Oct 12, 2026

View reviewed changes

jarnoldNI reviewed Oct 12, 2026

View reviewed changes

Comment thread src/nidmm/examples/nidmm_improve_dc_noise_rejection.py

doc: add self explainatory comments

ab9bcff

divakar-selvam07 requested a review from jarnoldNI October 12, 2026 15:45

jarnoldNI approved these changes Oct 12, 2026

View reviewed changes

divakar-selvam07 marked this pull request as ready for review October 12, 2026 16:46

divakar-selvam07 requested review from marcoskirsch, ni-jfitzger and vnktshr21 as code owners October 12, 2026 16:46

ni-jfitzger reviewed Oct 14, 2026

View reviewed changes

Comment thread src/nidmm/examples/nidmm_improve_dc_noise_rejection.py Outdated

NI-velmurugan and others added 5 commits October 15, 2026 12:50

Updating the comments for aperture time

c7ae2d0

Trigger CI build

4f00eb4

Merge branch 'users/diva/add-nidmm-improve-dc-noise-rejection-example…

ec9fbc7

…' of https://github.com/NI-velmurugan/nimi-python into users/diva/add-nidmm-improve-dc-noise-rejection-example

Trigger CI build

db7c272

nit: apply suggestions

c8757ec

Navigation Menu

Repository navigation

Adding Improve DC Noise Rejection example in NI-DMM - #2217

Adding Improve DC Noise Rejection example in NI-DMM#2217
divakar-selvam07 wants to merge 18 commits into
ni:masterfrom
NI-velmurugan:users/diva/add-nidmm-improve-dc-noise-rejection-example

divakar-selvam07 commented Oct 8, 2026

Uh oh!

codecov-commenter commented Oct 8, 2026 •

edited

Loading

Uh oh!

divakar-selvam07 commented Oct 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

divakar-selvam07 commented Oct 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

ni-jfitzger commented Oct 12, 2026

Uh oh!

jarnoldNI commented Oct 14, 2026

Uh oh!

ni-jfitzger Oct 14, 2026

Uh oh!

ni-jfitzger Oct 14, 2026

Uh oh!

divakar-selvam07 Oct 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

divakar-selvam07 commented Oct 8, 2026

What does this Pull Request accomplish?

List issues fixed by this Pull Request below, if any.

What testing has been done?

Uh oh!

codecov-commenter commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

divakar-selvam07 commented Oct 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

divakar-selvam07 commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ni-jfitzger commented Oct 12, 2026

Uh oh!

jarnoldNI commented Oct 14, 2026

Uh oh!

ni-jfitzger Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

ni-jfitzger Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

divakar-selvam07 Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-commenter commented Oct 8, 2026 •

edited

Loading

divakar-selvam07 commented Oct 9, 2026 •

edited

Loading

divakar-selvam07 Oct 22, 2026 •

edited

Loading