Repository navigation
Fix nirfsa and nirfsg deembedding system tests to match with new driver behaviour - #2233
Merged
Merged
Conversation
mohit-emerson
requested review from
marcoskirsch,
ni-jfitzger and
vnktshr21
as code owners
October 22, 2026 11:01
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2233 +/- ##
=======================================
Coverage 88.11% 88.12%
=======================================
Files 88 88
Lines 22832 22832
=======================================
+ Hits 20119 20121 +2
+ Misses 2713 2711 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vnktshr21
reviewed
Oct 22, 2026
vnktshr21
approved these changes
Oct 22, 2026
vnktshr21
changed the title
ni-jfitzger
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[] I've updated CHANGELOG.md if applicable.[ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Fixed
test_create_deembedding_sparameter_table_s2p_filein both RFSA & RFSG andtest_reset_with_optionsin RFSA to match with current behaviour of deembedding APIs.List issues fixed by this Pull Request below, if any.
None
What testing has been done?
PR Validations