Skip to content

Adding Digital Filtering in NI-Scope - #2234

Draft
NI-velmurugan wants to merge 1 commit into
ni:masterfrom
NI-velmurugan:users/velmurugan/add-niscope-digital-filtering
Draft

NI-velmurugan wants to merge 1 commit into
ni:masterfrom
NI-velmurugan:users/velmurugan/add-niscope-digital-filtering

Conversation

@NI-velmurugan

Copy link
Copy Markdown
Contributor
  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
    - [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

This PR adds niscope_digital_filtering.py, a Python adaptation of the LabVIEW niScope EX Digital Filtering.vi along with the pipeline changes required for using matplotlib package.

What testing has been done?

Manually tested the example using simulated hardware and the real hardware

@codecov-commenter

codecov-commenter commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.04%. Comparing base (cdbd8f2) to head (119c95d).

❗ There is a different number of reports uploaded between BASE (cdbd8f2) and HEAD (119c95d). Click for more details.

HEAD has 73 uploads less than BASE
Flag BASE (cdbd8f2) HEAD (119c95d)
nifakeunittests 15 5
nidcpowerunittests 15 5
nidigitalunittests 15 5
nimodinstunittests 15 5
nirfsaunittests 15 5
niscopeunittests 15 5
nitclkunittests 15 5
codegenunittests 3 1
nirfsasystemtests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2234      +/-   ##
==========================================
- Coverage   88.11%   83.04%   -5.08%     
==========================================
  Files          88       86       -2     
  Lines       22832    21563    -1269     
==========================================
- Hits        20119    17907    -2212     
- Misses       2713     3656     +943     
Flag Coverage Δ
codegenunittests 84.78% <ø> (ø)
nidcpowersystemtests 85.18% <ø> (-9.18%) ⬇️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.04% <ø> (ø)
nidigitalunittests 68.43% <ø> (ø)
nidmmsystemtests 92.33% <ø> (ø)
nifakeunittests 86.08% <ø> (ø)
nifgensystemtests 84.75% <ø> (-9.59%) ⬇️
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests ?
nirfsaunittests 63.40% <ø> (ø)
nirfsgsystemtests 70.08% <ø> (-11.10%) ⬇️
niscopesystemtests 89.99% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.66% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants