Skip to content

Adding Basic Arb Sequence Example in NI-FGEN - #2235

Draft
divakar-selvam07 wants to merge 5 commits into
ni:masterfrom
NI-velmurugan:users/diva/add-nifgen-basic-arb-sequence-example
Draft

divakar-selvam07 wants to merge 5 commits into
ni:masterfrom
NI-velmurugan:users/diva/add-nifgen-basic-arb-sequence-example

Conversation

@divakar-selvam07

Copy link
Copy Markdown
  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Adds nifgen_basic_arb_sequence.py, an example based on the LabVIEW “Fgen Basic Arb Sequence” VI.
  • Supports sine, triangle, square, and decreasing-ramp waveforms with configurable amplitudes and point counts.
  • Adds the example to the NI-FGEN examples documentation.

List issues fixed by this Pull Request below, if any.

None.

What testing has been done?

Manually validated with a simulated instrument and an actual hardware instrument.

@codecov-commenter

codecov-commenter commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.98%. Comparing base (cdbd8f2) to head (5d63a34).
⚠️ Report is 1 commits behind head on master.

❌ Your project status has failed because the head coverage (79.98%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (cdbd8f2) and HEAD (5d63a34). Click for more details.

HEAD has 77 uploads less than BASE
Flag BASE (cdbd8f2) HEAD (5d63a34)
nifakeunittests 15 5
nidcpowerunittests 15 5
nidigitalunittests 15 5
nimodinstunittests 15 5
nirfsaunittests 15 5
niscopeunittests 15 5
nitclkunittests 15 5
codegenunittests 3 1
nisesystemtests 1 0
nidigitalsystemtests 1 0
nirfsasystemtests 1 0
nidcpowersystemtests 1 0
nitclksystemtests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2235      +/-   ##
==========================================
- Coverage   88.11%   79.98%   -8.14%     
==========================================
  Files          88       71      -17     
  Lines       22832    16530    -6302     
==========================================
- Hits        20119    13221    -6898     
- Misses       2713     3309     +596     
Flag Coverage Δ
codegenunittests 84.78% <ø> (ø)
nidcpowersystemtests ?
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests ?
nidigitalunittests 68.43% <ø> (ø)
nidmmsystemtests 92.33% <ø> (ø)
nifakeunittests 86.08% <ø> (ø)
nifgensystemtests 84.75% <ø> (-9.59%) ⬇️
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests ?
nirfsaunittests 63.40% <ø> (ø)
nirfsgsystemtests 70.08% <ø> (-11.10%) ⬇️
niscopesystemtests 89.99% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests ?
niswitchsystemtests 81.66% <ø> (ø)
nitclksystemtests ?
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants