Repository navigation
validate: skip the vendored SDK - #54
Merged
Merged
Conversation
`init` vendors the SDK into vendor/nitrostack. `validate` walked it as project code, and nitrostack/testing applies @mcp_app to a class defined inside a function, so every vendored project that imported nitrostack.testing failed with "uses @mcp_app but no decorated application class was found after import". Compose's typecheck runs `validate`, so a NitroStudio build could not get past it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nitrostack-py validatewalkedvendor/nitrostack(the SDK copyinitvendors) as project code.nitrostack/testingapplies@mcp_appto a class defined inside a function, sovalidate_mcp_app_importsreported:NitroStudio Compose runs
validateas its Python typecheck, so a build could not get past it: the agent cannot fix SDK code and went idle (found by the Studio edge-case bench, Python arm).The validator now skips the vendored SDK directory (
VENDOR_REL) only; othervendor/content is still checked.Tests
test_validate_skips_the_vendored_sdkfails on main with the exact error above and passes with the fix.validate_projectnow returns no issues.🤖 Generated with Claude Code