Repository navigation
Conversation
Cross builds instantiate several shared generation actions in both toolsets, producing duplicate output rules that Ninja rejects. Register these actions once in the target toolset and explicitly share them with host consumers. Keep generator executables in the host toolset for cross builds. Refs: nodejs#66803 Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Capture the Rust target and host triples during configure for bundled Temporal cross builds. Use explicit Cargo targets and separate output directories so host and target archives do not share a build rule. Refs: nodejs#66803 Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix duplicate Rust archive rules in Temporal cross builds by capturing
CARGO_BUILD_TARGETand the Rust host triple during configure, then separating Cargo targets and output paths.This extends #66804 to Rust archives, which require separate host and target builds rather than a shared producer.
Validation: Make/Ninja × Release/Debug passed archive generation and Temporal FFI linking/execution with an rv64gc/lp64d-compatible sysroot, using QEMU for RISC-V.
Refs: #66803