Repository navigation
Conversation
Callback pointers returned by registerCallback() are plain bigint addresses, so they do not keep the owning DynamicLibrary reachable. If user code dropped the library without calling close(), the next GC ran ~DynamicLibrary(), which freed every ffi_closure. Native code still holding a callback pointer then jumped into freed trampoline memory and crashed the process, even though close() was never called. Make the library a strong reference while it has registered callbacks, and make it weak again when the last callback is unregistered or the library is closed. Callbacks released with unrefCallback() still count, because their trampolines remain live native memory. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
trivikr
added
the
ffi
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66842 +/- ##
==========================================
- Coverage 90.51% 90.50% -0.01%
==========================================
Files 797 797
Lines 278069 278078 +9
Branches 53416 53418 +2
==========================================
- Hits 251690 251671 -19
- Misses 16760 16800 +40
+ Partials 9619 9607 -12
🚀 New features to boost your workflow:
|
ShogunPanda
approved these changes
Oct 19, 2026
trivikr
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66841
registerCallback()returns a plainbigintaddress, which doesn't keep the owningDynamicLibraryreachable. If user code dropped the library without callingclose(), GC ran~DynamicLibrary()and freed everyffi_closure. Native code still holding a callback pointer then segfaulted, even though no documented rule was broken.This PR makes the library a strong reference while it has registered callbacks. It becomes weak again once the last callback is unregistered or
close()is called. Callbacks afterunrefCallback()still count, since their trampolines remain live native memory.Assisted-by: claude:opus-5.5