Repository navigation
Conversation
m90
approved these changes
Oct 27, 2026
m90
left a comment
Member
There was a problem hiding this comment.
This looks good, thank you! There's a couple of things in flight right now, so I'll merge this whenever all of this is ready for release.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #886.
BACKUP_JITTERwas applied unconditionally inrunScript, so a one-off run likedocker exec <container> backupwas delayed by a random amount of time, too. As discussed in the issue, jitter now only applies to runs that are triggered by a cron schedule.runScripttakes a newrunScriptOptsargument (same pattern asforegroundOpts) with ascheduledflag.command.schedulepassesscheduled: true,runAsCommand(one-off run) leaves it unset.jitterDelayhelper so it can be unit tested without a Docker daemon or a file lock. The behavior for scheduled runs is unchanged.Setting
BACKUP_JITTER=0mon invocation as a workaround is no longer necessary, but still works.Tested:
go test ./cmd/... ./internal/...,go build ./...andgo vet ./cmd/... ./internal/...pass,gofmt -lreports nothing.TestJitterDelaycovering a manual run with jitter configured (no delay), a scheduled run with zero and negative jitter (no delay), and a scheduled run with jitter configured (delay always within[0, max]).test/as they need Docker.