Repository navigation
remove ASCII armor from GPG asymmetric encryption - #890
Conversation
|
Thanks for working on this. Even if I'd say the current behavior is a bug, I'd still like to keep the option to produce armored output if needed (the bug is the inconsistent output, not the armored output itself. Also someone might have built a pipeline around the behavior by now). I'm fine with defaulting to binary output, but I wouldn't want to remove it entirely. Thanks. |
2f68819 to
2ab4545
Compare
|
I see what I can do. I will add a configuration option |
2ab4545 to
8dcf9e5
Compare
It's just as breaking as changing the output of asymmetric encryption from armored to binary without adding an option, no?
I'll merge your work into a feature branch and will pick up from there, thank you. |
* add option to ASCII armor asymmetric GPG output (#890) * Use custom string type for storing gpg output format * Use armored writer only when configured * Fix linting errors * Remove superfluous multi closer --------- Co-authored-by: Michuelnik <1367372+Michuelnik@users.noreply.github.com>
While symmetric GPG encryption produces binary output the asymmetric GPG encryption uses ASCII armored output that are roughly 30% larger than the binary output.
This patch omits the ASCII armoring part.
I've built the patch on my forked branch and used it on my production server successfully:
No tests were added since nothing was added, the existing tests should cover the new behaviour in the same way it did before. I successfully ran your lint, integration and unit tests on my fork, too.
No docs were changed since I assume the previous internal behaviour has been just a minor bug.