Repository navigation
chore(api): preserve client and resource compatibility - #4157
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed; 41 customizations removed; 31 generated baselines changed. Compared
1 more affected files are listed in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 39871563191 --repo openai/openai-python \
--name castiron-custom-code-39871563191-1 --dir /tmp/castiron-custom-code-39871563191-1
git apply --stat /tmp/castiron-custom-code-39871563191-1/custom-code.patch
cat /tmp/castiron-custom-code-39871563191-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin cfa0a79b6395bb0561b28879122a9f90a87cdada 75f2f0933467d5969f7d45d05200a5775b004674
python3 scripts/castiron/custom_code_report.py report \
--base cfa0a79b6395bb0561b28879122a9f90a87cdada \
--head 75f2f0933467d5969f7d45d05200a5775b004674 --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-75f2f0933467
cat /tmp/castiron-custom-code-75f2f0933467/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 70d4367ca84514a876ad431ab674472f92d1574a; no source issues found. The extracted client and resource helpers preserve the reviewed signatures, defaults, module bindings and request behavior. The reporting workflow now compares full review IDs without precision loss, and the generated-file metadata matches the source.
Static source review only; I did not run candidate code or tests. Hosted Python 3.10, Python 3.14, HTTPX2, lint, build and reporter checks passed. The optional browser job was cancelled during Chromium installation after its type checks passed; browser security checks did not run and remain unverified. This review leaves the PR in draft.
70d4367 to
a61dcfa
Compare
|
This draft is temporarily held for a generated API-reference correction: ten supported Videos and Assistants polling/streaming helpers lost their discovery entries. The methods remain present and callable. We are correcting the generator to derive documentation from the existing helper signatures, then will regenerate and request fresh review. The broader audit confirmed the other removed listings are valid replacements, linked relocations, or imports already invalid in the released baseline. No handwritten edits will be added to api.md. |
Castiron-Internal-PR: openai/openai-python-internal#327 Castiron-Source-SHA: 0246af3597c35d78183f67cd0c2fe96a02665522 Castiron-Public-Base-SHA: cfa0a79
a61dcfa to
75f2f09
Compare
## Changes being requested Python's generated-file custom patch is now empty after openai#4157, but the policy still allows 10,000 custom lines. Set `.castiron-ratchet.json` to schema v2 strict mode with `max_custom_patch_lines: 0`, leaving zero headroom for new customizations of generated files. This policy-only PR activates the existing verifier: generated paths, bytes, and Git modes must match the verified ownership manifest. The cleanup is already generated and merged, so no further generator change is needed to lower the ceiling. ## Additional context & links The trusted checker from main `56a55f243960e05e6268bb48ba6bf45299b8f90b` passes against candidate `1a9bb74cd036ce5a7fe920572263998f0f950fce`: - Existing Castiron suite: `python3 -m unittest discover -s scripts/castiron -p 'test_custom_code*.py'` — 221 tests, OK (1 skipped). - Policy isolation passes; only `.castiron-ratchet.json` changes. - 0 additions + 0 deletions = 0 custom lines; checked limit 0; 0 mixed files. - Strict verification passes with no violations against snapshot `b045ae7e94f055f952b812dfc4ddee314a691df7`. The report's base-policy headroom remains 10,000 until this policy lands; the proposed zero limit is already enforced when checking this PR. This activates strict policy on `main`; `next` has its own reviewed policy pin protocol.
Summary
Preserves existing client configuration, request handling, response parsing, and import paths.
Changes