Repository navigation
fix: preserve error events in Assistants streaming helpers - #4164
Closed
marcuswood-oai wants to merge 1 commit into
Closed
marcuswood-oai wants to merge 1 commit into
marcuswood-oai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the
event/dataenvelope for Assistants error events inruns.stream(),runs.submit_tool_outputs_stream(), andthreads.create_and_run_stream(), matching the regular streaming methods. Set the existing request option in both sync and async helpers so errors arrive asErrorEventrather than an incomplete event or a validation failure.One parameterized regression test covers the three helpers in both modes. All six cases fail before the fix and pass after it. Assistants and streaming suites pass with Pydantic v1 and v2 (81 passed, 34 skipped each). Changed-file lint, formatting, type checks, and the custom-code budget check pass.