Repository navigation
Reject failed library downloads before clearing installed libraries - #8591
Merged
danoli3 merged 2 commits intoOct 25, 2026
Merged
Conversation
danoli3
force-pushed
the
fix-library-download-validation
branch
from
October 16, 2026 01:38
32d249f to
20698fe
Compare
A package that matched its published digest is the release asset byte for byte, so verifyPackageArchives no longer decompresses it a second time (tar -tf on a .tar.bz2 costs about as much as extracting it). Packages without a digest, or every package when digests are unavailable or --skip-sha is given, are still opened before anything is removed. verifyPackagesAgainstMap records the matched names in SHA_VERIFIED_PKGS. verifyPackageArchives is indented with tabs, like the rest of the file. Tested: test-download-validation.sh under Bash 3.2 and 5.3; macOS download_libs: three verified bundles extract with no tar -tf, and with --skip-sha all three are checked first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Library downloads can report success after an HTTP failure and then reach extraction with a missing, truncated or HTML response instead of an archive. If remote digest lookup is unavailable, download_libs clears installed library directories before discovering the bad package, leaving a partial installation. Tar diagnostics are also suppressed.
Make curl downloads fail on HTTP errors and fail early across parallel transfers. Preserve curl/wget/wget2 exit status instead of allowing optional connection cleanup to mask it. Validate every downloaded tar/zip archive before any platform cleanup, and show extraction errors. Fetch digest metadata for the exact named release tag, with bounded retries/timeouts.
Observed with latest macOS bundles: extraction failed on bundle 3 after a 55.7 MiB transfer and unavailable digest map. The current published third archive is 40,576,583 bytes; an independent download matched GitHub's SHA-256 digest and fully extracted successfully. The transfer total matches bundles 1+2 alone, suggesting a missing/invalid third download rather than a broken published archive. The original failed file/HTTP response was not available for inspection.
Validation:
Adds a focused Ubuntu validation workflow. Does not rebuild or replace Apothecary release assets.