Repository navigation
VS: GLon12 renderer option, -DOF_USE_GLON12=1 sets the OF_USE_GLON12 MSBuild property - #678
Merged
Merged
Conversation
…penFrameworksCommon.props copies the GLon12 DLLs next to the exe); GLon12 renderer option for vs (angle / dawn only for Apple targets); CI check; bump version
Member
Author
|
|
…SE_GLON12_WARP=1)
…ibs/glon12/bin/vs
…roperty; GUI 0.107.0 (cmdline 0.114.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs openframeworks/openFrameworks#8601 (openFrameworksCommon.props copies the GLon12 DLLs next to the exe when
OF_USE_GLON12=1).visualStudioProject:-DOF_USE_GLON12[=1]also writes<OF_USE_GLON12>1</OF_USE_GLON12>to the vcxproj Globals PropertyGroup (still added to PreprocessorDefinitions / config.make like any define). Once per project on regeneratevswithGLon12 - OpenGL to Direct3D 12 (Mesa); ANGLE / Dawn only listed for osx / ios / macos, a choice that no longer applies resets to Default;GLon12 - WARP software (no GPU driver)addsOF_USE_GLON12=1,OF_USE_GLON12_WARP=1(app setsLIBGL_ALWAYS_SOFTWARE=truebefore the window underOF_USE_GLON12_WARP)scripts/vs/test_cmdline.sh:-DOF_USE_GLON12=1-> property in the vcxprojOF_USE_GLON12_WARP[=1]also written as an MSBuild property (#8601 props: WARP define)Tested on macOS:
-pvs -DOF_USE_GLON12=1-> property + define for Debug and Release, regenerate doesn't duplicate, other defines don't add it.withOF_USE_GLON12=1->no GLon12 files found in ...` error at generate (and the build fails with the same message from the props)