Repository navigation
Conversation
drgrice1
reviewed
Oct 23, 2026
File paths can contain special regex characters such as
".", "+", "(", ")", etc. Most paths are configured at the
server level and since "." is a wild card it has worked.
A few paths contain file names created by a user, so these
could possibly break the regex match or match the wrong thing.
Quote all instances of paths which are not meant to be regex
with `\Q$var\E`, which will prevent treating special characters
as regex.
Clarify the extra_headers and extra_ssl_headers urls are used as
regex strings to match the path in conf/webwork2.mojolicious.dist.yml.
Two new `^` anchors were also added for matching the prefix
of a path in SampleProblemViewer.pm and CourseActions.pm.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
somiaj
force-pushed
the
quote-regex-files
branch
from
October 23, 2026 16:17
6267b7f to
47bcede
Compare
drgrice1
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File paths can contain special regex characters such as ".", "+", "(", ")", etc. Most paths are configured at the server level and since "." is a wild card it has worked. A few paths contain file names created by a user, so these could possibly break the regex match or match the wrong thing.
Quote all instances of paths which are not meant to be regex with
\Q$var\E, which will prevent treating special characters as regex.Clarify the extra_headers and extra_ssl_headers urls are used as regex strings to match the path in conf/webwork2.mojolicious.dist.yml.
Two new
^anchors were also added for matching the prefix of a path in SampleProblemViewer.pm and CourseActions.pm.The AchievementEditor and AchievementNotificationEditor were left alone since I'm working on those in a separate PR.