Skip to content

[AI-FSSDK] [FSSDK-12958] Continue rule evaluation after local holdout hit - #407

Merged
Alex Yong (alexjoeyyong) merged 4 commits into
masterfrom
ai/alexjoeyyong/FSSDK-12958-local-holdout-flow-fix
Oct 27, 2026
Merged

Alex Yong (alexjoeyyong) merged 4 commits into
masterfrom
ai/alexjoeyyong/FSSDK-12958-local-holdout-flow-fix

Conversation

@alexjoeyyong

@alexjoeyyong Alex Yong (alexjoeyyong) commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Previously, a local holdout hit returned the holdout variation right away and skipped every remaining rule. Now a local holdout hit only removes the user from that rule. Evaluation continues with the next rule, and a holdout event is sent for each hit.

Changes

  • A local holdout hit on an experiment or delivery rule skips only that rule, then evaluation continues (no jump to Everyone Else)
  • The decide path sends one holdout impression per local holdout hit, whatever sendFlagDecisions is set to; DISABLE_DECISION_EVENT still suppresses them
  • The decision result now carries a list of holdout decisions; the existing single holdout decision field is kept (deprecated, holds the first hit)
  • Legacy APIs skip held-out rules without sending holdout events

Jira Ticket

FSSDK-12958

@alexjoeyyong
Alex Yong (alexjoeyyong) requested review from esrakartalOpt and a balanced review from Copilot and removed request for Copilot October 27, 2026 18:36

@esrakartalOpt esrakartalOpt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 FSC failure is not related to current changes. It is related to ODP. I'm creating a jira ticket for fixing the ruby-testapp related to ODP problem.

So, green light for merge ✅

@alexjoeyyong
Alex Yong (alexjoeyyong) merged commit e1c94f7 into master Oct 27, 2026
8 of 10 checks passed
@alexjoeyyong
Alex Yong (alexjoeyyong) deleted the ai/alexjoeyyong/FSSDK-12958-local-holdout-flow-fix branch October 27, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants