Repository navigation
[AI-FSSDK] [FSSDK-12958] Continue rule evaluation after local holdout hit - #407
Merged
Alex Yong (alexjoeyyong) merged 4 commits intoOct 27, 2026
Conversation
Alex Yong (alexjoeyyong)
requested review from
Matjaz Pirnovar (Mat001) and
esrakartalOpt
and removed request for
esrakartalOpt
October 27, 2026 17:31
Alex Yong (alexjoeyyong)
requested review from
esrakartalOpt
and
a balanced review from Copilot
and removed request for
Copilot
October 27, 2026 18:36
esrakartalOpt
approved these changes
Oct 27, 2026
esrakartalOpt
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 FSC failure is not related to current changes. It is related to ODP. I'm creating a jira ticket for fixing the ruby-testapp related to ODP problem.
So, green light for merge ✅
Alex Yong (alexjoeyyong)
deleted the
ai/alexjoeyyong/FSSDK-12958-local-holdout-flow-fix
branch
October 27, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, a local holdout hit returned the holdout variation right away and skipped every remaining rule. Now a local holdout hit only removes the user from that rule. Evaluation continues with the next rule, and a holdout event is sent for each hit.
Changes
Jira Ticket
FSSDK-12958