Repository navigation
add Base64Slice, the borrowed counterpart of Base64Vec - #13
Merged
sunshowers merged 1 commit intoOct 21, 2026
Conversation
sunshowers
added this pull request to stack #16
October 21, 2026 06:23
I'd like to use this in a static context. `Base64Slice` is just a borrowed `[u8]` and doesn't need alloc. To handle that we need to write a displayer ourselves, but that isn't too bad -- mostly just about computing parameters like width and fill ourselves, and adding tests to ensure the display impls are the same.
sunshowers
force-pushed
the
jj-stack/add-base64slice-the-borrowed-counterpart-of-base64vec-rklwmvyl
branch
from
October 21, 2026 06:40
5cb617b to
1748fcd
Compare
Collaborator
Author
Revision history
Generated by jj-stack from this pull request's force-push history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to use this in a static context.
Base64Sliceis just a borrowed[u8]and doesn't need alloc. To handle that we need to write a displayer ourselves, but that isn't too bad -- mostly just about computing parameters like width and fill ourselves, and adding tests to ensure the display impls are the same.