Repository navigation
ext/session: Open session files with O_CLOEXEC - #24376
Merged
Merged
Conversation
devnexen
reviewed
Oct 16, 2026
|
|
||
| /* O_NOFOLLOW to prevent us from following evil symlinks */ | ||
| data->fd = VCWD_OPEN_MODE(buf, O_CREAT | O_RDWR | O_BINARY | O_NOFOLLOW, data->filemode); | ||
| data->fd = VCWD_OPEN_MODE(buf, O_CREAT | O_RDWR | O_BINARY | O_NOFOLLOW |
Member
There was a problem hiding this comment.
if I were you, I would build the flag via a variable before the call instead wdyt ?
Contributor
Author
There was a problem hiding this comment.
Makes sense and fixes Windows tests, thanks.
Set close-on-exec atomically when opening the session file instead of issuing a separate fcntl(F_SETFD) call afterwards. This saves one syscall per request and closes the window in which the descriptor could leak into a child process forked by another thread. The fcntl() fallback is kept for platforms without O_CLOEXEC.
jorgsowa
force-pushed
the
session-files-fewer-syscalls
branch
from
October 16, 2026 19:02
f03b954 to
d85d356
Compare
devnexen
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set close-on-exec atomically when opening the session file instead of issuing a separate
fcntl(F_SETFD)call afterwards. This saves one syscall per request and closes the window in which the descriptor could leak into a child process forked by another thread. Thefcntl()fallback is kept for platforms withoutO_CLOEXEC.