Skip to content

tree: generate BEGIN/END_EXTERN_C() macros for arginfos - #24378

Draft
Girgias wants to merge 17 commits into
php:masterfrom
Girgias:2026-10-gen_stub-extern-c
Draft

tree: generate BEGIN/END_EXTERN_C() macros for arginfos#24378
Girgias wants to merge 17 commits into
php:masterfrom
Girgias:2026-10-gen_stub-extern-c

Conversation

@Girgias

@Girgias Girgias commented Oct 16, 2026

Copy link
Copy Markdown
Member

So that one can include the header without needing to do this on the inclusion site.

Primarily to fix ext/intl which more or less always includes headers with BEGIN_EXTERN_C() causing issues if one wants to add generic APIs. (Which is what I initially was working on)

Girgias added 17 commits October 16, 2026 21:35
@Girgias
Zend: move zend_empty_array to BEGIN_EXTERN_C section
459da1f
@Girgias
tree: wrap arginfo in C extern blocks
394984b
@Girgias
Fix ext/intl
46cc55d
@Girgias
intl: stop including headers as C extern
2123eb6
@Girgias
intl: stop including headers as C extern
0e69289
@Girgias
intl: stop including headers as C extern
934978d
@Girgias
intl: stop including headers as C extern
250f5ee
@Girgias
intl: stop including headers as C extern
023bd4c
@Girgias
intl: stop including headers as C extern
5459042
@Girgias
intl: stop including headers as C extern
276abb8
@Girgias
intl: stop including headers as C extern
587b4eb
@Girgias
intl: stop including headers as C extern
a84b649
@Girgias
intl: stop including headers as C extern
c3a2ef0
@Girgias
intl: stop including headers as C extern
f404e8b
@Girgias
intl: stop including headers as C extern
89f9b4c
@Girgias
intl: stop including headers as C extern
b823170
@Girgias
intl: stop including headers as C extern
9b3ae8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstogov dstogov Awaiting requested review from dstogov dstogov will be requested when the pull request is marked ready for review dstogov is a code owner
@bukka bukka Awaiting requested review from bukka bukka will be requested when the pull request is marked ready for review bukka is a code owner
@LamentXU123 LamentXU123 Awaiting requested review from LamentXU123 LamentXU123 will be requested when the pull request is marked ready for review LamentXU123 is a code owner
@devnexen devnexen Awaiting requested review from devnexen devnexen will be requested when the pull request is marked ready for review devnexen is a code owner
@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate will be requested when the pull request is marked ready for review kocsismate is a code owner
@TimWolla TimWolla Awaiting requested review from TimWolla TimWolla will be requested when the pull request is marked ready for review TimWolla is a code owner
@jorgsowa jorgsowa Awaiting requested review from jorgsowa jorgsowa will be requested when the pull request is marked ready for review jorgsowa is a code owner
@DanielEScherzer DanielEScherzer Awaiting requested review from DanielEScherzer DanielEScherzer will be requested when the pull request is marked ready for review DanielEScherzer is a code owner
@zeriyoshi zeriyoshi Awaiting requested review from zeriyoshi zeriyoshi will be requested when the pull request is marked ready for review zeriyoshi is a code owner
@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi will be requested when the pull request is marked ready for review SakiTakamachi is a code owner
@NattyNarwhal NattyNarwhal Awaiting requested review from NattyNarwhal NattyNarwhal will be requested when the pull request is marked ready for review NattyNarwhal is a code owner
@kamil-tekiela kamil-tekiela Awaiting requested review from kamil-tekiela kamil-tekiela will be requested when the pull request is marked ready for review kamil-tekiela is a code owner
@alexdowad alexdowad Awaiting requested review from alexdowad alexdowad will be requested when the pull request is marked ready for review alexdowad is a code owner
@youkidearitai youkidearitai Awaiting requested review from youkidearitai youkidearitai will be requested when the pull request is marked ready for review youkidearitai is a code owner
@derickr derickr Awaiting requested review from derickr derickr will be requested when the pull request is marked ready for review derickr is a code owner
@adoy adoy Awaiting requested review from adoy adoy will be requested when the pull request is marked ready for review adoy is a code owner

Assignees

No one assigned

Labels

ABI break Category: Build System Category: Engine Extension: bcmath Extension: bz2 Extension: calendar Extension: com_dotnet Extension: ctype Extension: curl Extension: date Extension: dba Extension: dom Extension: enchant Extension: exif Extension: ffi Extension: fileinfo Extension: filter Extension: ftp Extension: gd Extension: gettext Extension: gmp Extension: hash Extension: iconv Extension: intl Extension: json Extension: ldap Extension: libxml Extension: mbstring Extension: mysqli Extension: odbc Extension: opcache Extension: openssl Extension: pcntl Extension: pcre Extension: pdo (core) Extension: pdo_dblib Extension: pdo_firebird Extension: pdo_mysql Extension: pdo_odbc Extension: pdo_pgsql Extension: pdo_sqlite Extension: pgsql Extension: phar Extension: posix Extension: random Extension: readline Extension: reflection Extension: session Extension: shmop Extension: simplexml Extension: snmp Extension: soap Extension: sockets Extension: sodium Extension: spl Extension: sqlite3 Extension: standard Extension: sysvmsg Extension: sysvsem Extension: sysvshm Extension: tidy Extension: tokenizer Extension: uri Extension: xml Extension: xmlreader Extension: xmlwriter Extension: xsl Extension: zend_test Extension: zip Extension: zlib SAPI: apache2handler SAPI: cgi SAPI: cli SAPI: fpm SAPI: litespeed SAPI: phpdbg

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Girgias