Repository navigation
Fix calendar - #2043
Merged
Merged
Fix calendar#2043
Conversation
Fix typo introduced in b24d310. Remove PHPStan overrides for those bugs.
mattstauffer
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
October 24, 2026 00:19
Contributor
|
📊 Regression report for commit c0a96a8 is at https://web-php-regression-report-pr-2043.preview.thephp.foundation |
Contributor
|
🚀 Preview for commit c0a96a8 is available at https://web-php-pr-2043.preview.thephp.foundation |
svpernova09
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: The calendar page is erroring out midpage because of a typo introduced recently, and then PHPStan-ignored. This PR reverts that code back to what it used to do.
Fix typo introduced in b24d310 that was keeping all calendar events from outputting to the page; likely a find-replace or PHPStorm refactor ended up replacing
date("...")withcal . phpdate("..."). PHPStan missed this because it was rolled up in the baseline.Current status:
php.net/cal.phpjust cuts off without even rendering the ending of the page.Note: This feature reads
events.csvwhich isn't in this repo. I assume it's there in prod?