Skip to content

More Choclatey error handling #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iMattPro merged 1 commit into from
Oct 19, 2026
Merged

More Choclatey error handling #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,13 +698,19 @@ jobs:
$httpErrors = $webConfigXml.CreateElement('httpErrors')
$httpErrors.SetAttribute('errorMode', 'Detailed')
[void]$systemWebServer.AppendChild($httpErrors)
$appCmd = Join-Path $env:windir 'System32\inetsrv\appcmd.exe'
$rewriteInstalled = $false
try {
choco install urlrewrite -y --no-progress
# Native command failures do not necessarily throw in PowerShell.
if ($LASTEXITCODE -ne 0) {
throw "Chocolatey URL Rewrite installation exited with code $LASTEXITCODE."
}
# Chocolatey can report success even when its feed failed and no packages were installed.
$iisModules = @(& $appCmd list modules /text:MODULE.NAME)
if ($LASTEXITCODE -ne 0 -or $iisModules -notcontains 'RewriteModule') {
throw 'IIS URL Rewrite module is not registered after installation.'
}
$rewriteInstalled = $true
} catch {
Write-Warning "URL Rewrite installation failed; continuing without rewrite-specific IIS configuration. $_"
Expand All @@ -731,6 +737,11 @@ jobs:
New-WebHandler -Name "PHP-FastCGI" -Path "*.php" -Modules FastCgiModule -ScriptProcessor "C:\tools\php\php-cgi.exe" -Verb '*' -ResourceType Either
iisreset
NET START W3SVC
$iisConfiguration = & $appCmd list config 'phpBBTest/'
if ($LASTEXITCODE -ne 0) {
Get-Content $webConfig
throw "IIS rejected the phpBB test site configuration: $iisConfiguration"
}
mkdir "${env:GITHUB_WORKSPACE}\phpBB3\phpBB\cache\test"
mkdir "${env:GITHUB_WORKSPACE}\phpBB3\phpBB\cache\installer"
icacls "${env:GITHUB_WORKSPACE}\phpBB3\phpBB\cache" /grant Users:F /T
Expand Down
Loading