Repository navigation
fix(web): diagnostics cards use one border radius - #22906
Saikrishna1876 wants to merge 10 commits into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused web UI fix that removes duplicated inner card styling and inherits the existing SettingsGroup radius, eliminating mismatched corners and overlapping borders. It does not alter diagnostics behavior, data handling, product defaults, or application interfaces. You can add or adjust custom eligibility rules. Learn more. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update telemetry wrapper styles apps/web/src/components/settings/ResourceTelemetryDiagnostics.tsx |
The T3 system footprint, host and collection, resource timeline, live process tree, and instrumented application I/O wrappers now use inherited rounding and omit their own border, background, and shadow. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Suggested reviewers: macroscopeapp
Merge Risk: 
Minimal · up to 09a42
-
The diagnostics card styling is mergeable after normal checks.
Pre-merge checks: 
4
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Problem
Settings > Diagnostics renders five resource telemetry cards with two borders and different corner radii. On main, the shared SettingsGroup has a 14px radius while each nested card has an 18px radius, leaving overlapping outlines at the corners.
Change
Let SettingsGroup own each card's border, background, and shadow. The inner wrapper inherits its radius to keep content clipped to the same shape. This fixes Resource monitor, Host & collection, Resource timeline, Live process tree, and Instrumented application I/O on web and desktop's shared web UI.
Scope and approval
This qualifies as a small, focused fix for an obvious visual bug. It removes duplicate card styling from five wrappers in one component. Native mobile uses separate diagnostics UI.
Verification
vp run check:changedpassed format, lint, knip, affected typechecks, and the adjacent test selected by the script.Before:
After:
Additional screenshots: Host & collection before, after, 390px browser after.
Written with GPT-6.1 Sol in the Codex harness.