Skip to content

fix(web): diagnostics cards use one border radius - #22906

Open
Saikrishna1876 wants to merge 10 commits into
pingdotgg:mainfrom
Saikrishna1876:fix/diagnostics-border-radius
Open

Saikrishna1876 wants to merge 10 commits into
pingdotgg:mainfrom
Saikrishna1876:fix/diagnostics-border-radius

Conversation

@Saikrishna1876

Copy link
Copy Markdown
Contributor

Problem

Settings > Diagnostics renders five resource telemetry cards with two borders and different corner radii. On main, the shared SettingsGroup has a 14px radius while each nested card has an 18px radius, leaving overlapping outlines at the corners.

Change

Let SettingsGroup own each card's border, background, and shadow. The inner wrapper inherits its radius to keep content clipped to the same shape. This fixes Resource monitor, Host & collection, Resource timeline, Live process tree, and Instrumented application I/O on web and desktop's shared web UI.

Scope and approval

This qualifies as a small, focused fix for an obvious visual bug. It removes duplicate card styling from five wrappers in one component. Native mobile uses separate diagnostics UI.

Verification

  • vp run check:changed passed format, lint, knip, affected typechecks, and the adjacent test selected by the script.
  • Chromium at 1440x1100 reproduced 14px outer and 18px inner radii with two 1px borders on all five cards. After the fix, both radii are 14px and each inner border is 0px. The same assertions passed at 390x1000.
  • CodeRabbit reviewed the committed diff with the personal profile and reported zero findings. Greptile could not run because the repository is not connected.
  • Browser screenshots used isolated worktree state. The native resource-monitor binary was unavailable, so telemetry displays its unavailable state. A packaged Electron client was not launched.

Before:

Resource monitor before

After:

Resource monitor after

Additional screenshots: Host & collection before, after, 390px browser after.

Written with GPT-6.1 Sol in the Codex harness.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Oct 21, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 0200554

Macroscope's review found this PR approvable — This is a focused web UI fix that removes duplicated inner card styling and inherits the existing SettingsGroup radius, eliminating mismatched corners and overlapping borders. It does not alter diagnostics behavior, data handling, product defaults, or application interfaces.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 9d962b8 and 09a4249.

Files selected for processing: 1
  • apps/web/src/components/settings/ResourceTelemetryDiagnostics.tsx
Files skipped from review as they are similar to previous changes: 1
  • apps/web/src/components/settings/ResourceTelemetryDiagnostics.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

Five resource telemetry section wrappers now use inherited corner rounding instead of setting their own border, background, and shadow. The changes do not alter telemetry behavior or data display.

Changes: Telemetry wrapper styling

Layer / File(s) Summary
Update telemetry wrapper styles
apps/web/src/components/settings/ResourceTelemetryDiagnostics.tsx
The T3 system footprint, host and collection, resource timeline, live process tree, and instrumented application I/O wrappers now use inherited rounding and omit their own border, background, and shadow.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: macroscopeapp

Merge Risk: Minimal · up to 09a42

The diagnostics card styling is mergeable after normal checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title is concise, uses the repository's conventional commit format, and clearly describes the main UI fix: consistent border radius for diagnostics cards.
Description check Passed The description includes all required sections. It explains the visual problem, the implementation, the focused-scope rationale, verification results, screenshots, and unavailable test conditions.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant