Repository navigation
Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
2 of 6 tasks
samperman
approved these changes
Oct 15, 2026
samperman
left a comment
samperman
left a comment
Collaborator
There was a problem hiding this comment.
nice improvement. I blame myself 😆
vrsarah
changed the base branch from
main
to
connect-cloud-sso-credentials-error
October 15, 2026 22:15
vrsarah
changed the base branch from
connect-cloud-sso-credentials-error
to
main
October 15, 2026 22:15
vrsarah
changed the base branch from
main
to
connect-cloud-sso-credentials-error
October 15, 2026 22:21
vrsarah
merged commit Oct 15, 2026
7c3d3f4
into
connect-cloud-sso-credentials-error
27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
The Posit Connect Cloud credentials passed with
--client-idand--client-secretare OAuth client credentials created at login.posit.cloud/identity/credentials. They act as the user who created them, with that user's roles. The CLI called them a "service account" credential, which suggests a separate identity. This renames them to "client credentials", matching the R package (connectCloudClientCredentials()).Follow-up to the wording discussion in #868.
Type of Change
Approach
Changes user-facing text only: README,
docs/deploying.md,--client-id/--client-secrethelp, error messages, and thersconnect listlabel (Service account client ID:is nowClient ID:), plus the matching comments and docstrings. Internal names such as theservice_accountvariable are unchanged.service_account_nameinmodels.pyis a Posit Connect content field and is not related.Automated Tests
Updated the tests that assert on the changed messages and the
rsconnect listoutput, and renamed tests that referred to service accounts. Full suite passes.Directions for Reviewers
Run
rsconnect add --helpandrsconnect listwith a saved Connect Cloud entry that has a client ID.Checklist
rsconnect-python-tests-at-nightworkflow in Connect against this feature branch.