Repository navigation
Floxis: validate bid impression against outbound request - #4676
Open
floxis-admin wants to merge 3 commits into
Open
floxis-admin wants to merge 3 commits into
floxis-admin wants to merge 3 commits into
Conversation
CTMBNara
requested changes
Oct 26, 2026
Comment on lines
+558
to
+572
| @Test | ||
| public void makeBidsShouldReturnErrorWhenBidImpIdNotFoundAndMTypePresent() throws Exception { | ||
| // given | ||
| final BidRequest bidRequest = givenBidRequest(identity()); | ||
| final BidResponse bidResponse = givenBidResponse(Bid.builder().impid("no-such-imp").mtype(1).build()); | ||
| final BidderCall<BidRequest> httpCall = givenHttpCall(bidRequest, mapper.writeValueAsString(bidResponse)); | ||
|
|
||
| // when | ||
| final Result<List<BidderBid>> result = target.makeBids(httpCall, bidRequest); | ||
|
|
||
| // then | ||
| assertThat(result.getValue()).isEmpty(); | ||
| assertThat(result.getErrors()).containsExactly( | ||
| BidderError.badServerResponse("unable to find impression no-such-imp for bid")); | ||
| } |
Comment on lines
+597
to
+598
| assertThat(result.getValue()).extracting(bidderBid -> bidderBid.getBid().getImpid()) | ||
| .containsExactly("imp-1"); |
Collaborator
There was a problem hiding this comment.
assertThat(result.getValue())
.extracting(BidderBid::getBid)
.extracting(Bid::getImpid)
.containsExactly("imp-1");
CTMBNara
requested changes
Oct 26, 2026
Comment on lines
539
to
556
| @@ -555,6 +555,51 @@ public void makeBidsShouldReturnErrorWhenBidImpIdNotFound() throws Exception { | |||
| "unable to find impression no-such-imp for bid")); | |||
| } | |||
Contributor
Author
osulzhenko
approved these changes
Oct 27, 2026
CTMBNara
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Context
Floxis splits requests by seat and routing host. Bid parsing looked impressions up in the original request rather than the outgoing request that produced the response, so a response could return a bid for another group's impression. A supplied
mtypealso skipped the impression lookup entirely.Change
Each response bid's
impidis checked against the outgoing request's impressions (httpCall.getRequest().getPayload().getImp()) before its media type is resolved, including whenmtypeis set. Bids that fail the check return the existingbad_server_responseerror and are skipped; other bids in the same response are kept.Only the Floxis adapter and its unit tests change.
Test plan
FloxisBidderTest(28 tests) and checkstyle pass.makeBidsShouldReturnErrorWhenBidImpIdIsNotInOutgoingRequestcovers a bid for an impression that is in the original request but not in the outgoing one, withmtypeset. It fails against the current master adapter.