Skip to content

Refactoring: Rename confusing variable #4692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CTMBNara wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −12
Open

Refactoring: Rename confusing variable #4692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/main/java/org/prebid/server/privacy/PrivacyExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,6 @@ public class PrivacyExtractor {
private static final String DEFAULT_GPP_VALUE = "";
private static final List<Integer> DEFAULT_GPP_SID_VALUE = Collections.emptyList();

/**
* Retrieves:
* <p><ul>
* <li>gdpr from regs.ext.gdpr
* <li>consent from user.consent
* <li>us_privacy from regs.ext.us_privacy
* <li>coppa from regs.coppa
* </ul><p>
* And construct {@link Privacy} from them. Use default values in case of invalid value.
*/
public Privacy validPrivacyFrom(BidRequest bidRequest, List<String> errors) {
return extractPrivacy(bidRequest.getRegs(), bidRequest.getUser(), errors);
}
Expand Down Expand Up @@ -91,8 +81,8 @@ private static List<Integer> parseGppSid(String gppSid) {
}

private Privacy extractPrivacy(Regs regs, User user, List<String> errors) {
final Integer extRegsGdpr = regs != null ? regs.getGdpr() : null;
final String gdpr = extRegsGdpr != null ? Integer.toString(extRegsGdpr) : null;
final Integer regsGdpr = regs != null ? regs.getGdpr() : null;
final String gdpr = regsGdpr != null ? Integer.toString(regsGdpr) : null;
final String consent = user != null ? user.getConsent() : null;
final String usPrivacy = regs != null ? regs.getUsPrivacy() : null;
final Integer coppa = regs != null ? regs.getCoppa() : null;
Expand Down
Loading