Skip to content

SelectPanel: Improve rendering performance - #8613

Draft
alexus37 wants to merge 1 commit into
mainfrom
agents/implement-primer-react-8607-updates
Draft

alexus37 wants to merge 1 commit into
mainfrom
agents/implement-primer-react-8607-updates

Conversation

@alexus37

Copy link
Copy Markdown

Closes #8607

Improves SelectPanel rendering efficiency while preserving existing interaction behavior. No visual changes are expected.

Changelog

New

None.

Changed

  • SelectPanel avoids redundant follow-up rendering when opening or receiving item and selection updates.

Removed

None.

Rollout strategy

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None

Testing & Reviewing

  • npx vitest run packages/react/src/SelectPanel/SelectPanel.test.tsx — passed (185 tests)
  • npm run build — passed
  • npm test -- --run — passed (160 files, 2905 tests)
  • npm run type-check — passed
  • npm run lint — passed
  • npm run lint:css — passed
  • npm run format:diff — passed
  • The default SelectPanel Storybook story loaded successfully.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5e495ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

This branch was successfully deployed

2 active deployments
storybook-preview-8613 — 5e495ce7 Deployed Oct 22, 2026 by github-actions[bot]
github-pages — 5e495ce7 Deployed Oct 22, 2026 by alexus37 via deploy-preview #33866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SelectPanel synchronizes selection and loading state from effects

1 participant