Skip to content

test: migrate batch 2 component tests to browser locators - #8614

Open
tay1orjones wants to merge 1 commit into
mainfrom
tay1orjones-rtl-migration-batch-2
Open

tay1orjones wants to merge 1 commit into
mainfrom
tay1orjones-rtl-migration-batch-2

Conversation

@tay1orjones

@tay1orjones tay1orjones commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Related to github/primer#6369.

Continue the browser locator migration so interactions exercise native browser behavior. Keeps RTL rendering and lifecycle handling, with the existing assertions and snapshots intact.

Changelog

New

Changed

  • Migrate Autocomplete, Avatar, AvatarStack, Banner, Blankslate, BranchName, Breadcrumbs, Breadcrumbs.Item, and ButtonGroup tests to Vitest browser locators and interactions.

Removed

Rollout strategy

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None

Testing & Reviewing

Check that Autocomplete still verifies inline selection and blur behavior, Banner clicks the visible responsive action, and Breadcrumbs preserves keyboard focus and overflow behavior. Native structural queries remain for markup assertions.

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b09aea16-dbd5-4870-8c38-7b24b604ae64
@changeset-bot

changeset-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e6ee3c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tay1orjones tay1orjones added the skip changeset This change does not need a changelog label Oct 22, 2026
@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@tay1orjones tay1orjones changed the title migrate second test batch to browser locators test: migrate component tests to browser locators Oct 22, 2026
@tay1orjones tay1orjones changed the title test: migrate component tests to browser locators test: migrate batch 2 component tests to browser locators Oct 22, 2026
@tay1orjones
tay1orjones marked this pull request as ready for review October 22, 2026 20:09
@tay1orjones
tay1orjones requested a review from a team as a code owner October 22, 2026 20:09
@tay1orjones
tay1orjones requested review from llastflowers and a balanced review from Copilot and removed request for Copilot October 22, 2026 20:09

This branch was successfully deployed

2 active deployments
storybook-preview-8614 — e6ee3c5c Deployed Oct 22, 2026 by github-actions[bot]
github-pages — e6ee3c5c Deployed Oct 22, 2026 by tay1orjones via deploy-preview #33870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant