Repository navigation
feat(sh1pt.com): Sign in with CoinPay - #1053
Merged
Merged
Conversation
CoinPay is the fleet's master account. Adds "Sign in with CoinPay" first on /login and "Sign up with CoinPay" on /waitlist, and a CoinPay card on the dashboard (Connect / Disconnect), via @profullstack/coinpay-onboard 0.3.1: auth code + PKCE S256 + state + nonce, client secret on the exchange, id_token iss/aud/exp/nonce and userinfo sub checks. - Bound by the CoinPay sub (public.coinpay_identities), never by email. A CoinPay email matching an existing account gets a new account on a placeholder auth email; the CoinPay email is contact info only. - State pinned to the browser by an httpOnly cookie, spent from a server-side coinpay_pending row (single use, 10 minutes). - Connect needs the signed-in user who started it to finish it. - Disconnect is refused when CoinPay is the only way in. - Session minted server side (generateLink hash + verifyOtp), as crawlproof. - Invite bonuses are never paid to a CoinPay-made account (no proven mailbox), and its first login does not accept an invite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
ThreatCrush Security Scan54 finding(s) HIGH/CRITICAL: 1 | MEDIUM: 18 | LOW: 35
…and 4 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoinPay is the fleet's master account: this adds Sign in with CoinPay to sh1pt.com.
@profullstack/coinpay-onboard0.3.1): auth code + PKCE S256 + state + nonce, exact redirecthttps://sh1pt.com/api/v1/coinpay/oauth/callback, client secret on the code exchange, id_token iss/aud/exp/nonce check, userinfo sub match. State pinned to the browser by an httpOnly cookie and spent from a server-side single-usecoinpay_pendingrow.sub(public.coinpay_identities, RLS on, service role only). A CoinPay email matching an existing account never signs into it: a new auth user on a@coinpay-users.sh1pt.complaceholder is created and the CoinPay email kept as contact info. Session is minted server side (admin generateLink hash + verifyOtp), the crawlproof feat(cloud): add Linode / Akamai cloud adapter #405 pattern.bonusVerdictdenies invite bonuses to a placeholder account (no_proven_email), and a CoinPay-created account does not accept an invite on first login.sh1pt loginpairs through/cli/login, which uses the web session, so it inherits CoinPay.20261029063000_coinpay_identities.sql(already applied on dev2 by hand +notify pgrst).Tests:
sites/sh1pt.com/lib/coinpay-signin.test.ts(email collision, connect needs the same user, forged/missing/replayed/expired state, disconnect guard, invite bonus). Site lib suites 45/45,tsc --noEmitclean.🤖 Generated with Claude Code