Repository navigation
Fix W3BS name-host page assets - #271
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The W3BS name gateway intercepted every request on a registered name host, returning the landing-page HTML for CSS, JavaScript, the web manifest, and the service worker. The fallback page also left its internal navigation on the name host.
For active names without a published destination, pass those public shell assets to the existing static handlers and point internal links back to the primary W3BS site. Names with a destination keep redirecting to that destination. Add an HTTP regression test for both paths.
Local verification:
bun run checkpassed.bun test test/net-hosting.test.mjspassed.bun test --test-concurrency=1 test/*.test.mjspassed: 159 passed, 4 skipped.bun run conformancepassed.bun run test:browserpassed: 8 tests.fleet-screenwebsocket timing test; that file passes by itself and the serialized suite passes.