Repository navigation
port upstream pstack through 0.15.28 - #12
Conversation
Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
left a comment
There was a problem hiding this comment.
verdict: changes requested (comment review, same-account limit).
content is clean. diffed every changed file against upstream d457567: both formal-verification skills match byte for byte except /pstack: prefixes and disable-model-invocation: true → triggers: [user]. poteto-help, recipes, guide 06 and 09 lines are upstream verbatim modulo prefix, and the 09 anchor resolves to ## Prove a property with a formal verification skill. #716/#721/#724 touched nothing else under pstack/ outside harness/, readme row, and .cursor-plugin/; skips are justified. d457567 is still the latest upstream commit on pstack/. versions 0.15.28 in plugin.json, .devin-plugin/plugin.json, readme. ci green. no issue to link.
blocking: no harness proof. need, on head e63d618:
devin plugins install(a--localwrapper pinned to the full head sha is fine; symlink-only is not) +devin plugins listshowing pstack 0.15.28- the installed copy showing
maintain-formal-verification-skillregistered and the changedcreate-formal-verification-skill/poteto-helptext, or a real devin turn invoking them
post it as a comment or in the body and i'll re-review.
harness proofReal Devin CLI on a local box (no cloud agent, no git clone). PR head
None of the three skill runs hit a permission rejection. Afterwards, 0. clean slate1–2. install + list3. installed copy (
|
caelaxie
left a comment
There was a problem hiding this comment.
verdict: approved (comment review, same-account limit).
harness proof in #12 (comment) holds on head e63d618:
devin plugins install --localvia a wrapper pinned to the full head shae63d6180d2bea58fb58c5763ae738106a89c727e, with devin fetching from github (not a symlink). it started from a clean slate after removing the #11 wrapper.devin plugins list/infoshowpstack v0.15.28.- the installed cache copy has
maintain-formal-verification-skill/SKILL.mdwithtriggers: [user], and the changedcreate-formal-verification-skilllines (tla+ default, the no-verifier fallback, the maintain pointer) plus the poteto-help bullet, table row, and recipe. the sha256 of each installed file matches raw @e63d618and differs frommain. - all three skills ran in real devin turns with exit 0. there were no permission rejections and nothing was written.
content was already verified against upstream d457567, and ci (Validate plugin) is green on the head. squash-merging pinned to e63d618.
synced to
d457567. later commits on upstreammainthroughddf824ado not touchpstack/. version is0.15.28inplugin.json,.devin-plugin/plugin.json, and the readme marker.ported:
6b78e9f(#721) create-formal-verification-skill: tla+ is the default for event-order questions in any language, and when no verifier runs on the language the agent says so and tests the real code with generated inputs.7b353f7(#716) add maintain-formal-verification-skill. create-formal-verification-skill records covered code and the sync commit. poteto-help routing table, guide pages 6 and 9, and recipes mention it. slash commands keep the/pstack:prefix.disable-model-invocation: truestaystriggers: [user].d457567(#724) guide page 6 matches the create-formal-verification-skill tool choice, and the version bumps to0.15.28. the same bump is in.devin-plugin/plugin.jsonand the readme marker, which is where this repo records the version.skipped:
harness/pstack/claude-code/copies in #721, #716, and #724. this port does not carry the generated claude code tree.pstack/.cursor-plugin/plugin.json. cursor packaging. the version bump lands in.devin-plugin/plugin.jsoninstead./maintain-formal-verification-skill. this port's readme is a pointer, not a copy of the upstream catalog. the version marker is bumped. the skill is indexed in poteto-help, the guide, and recipes.