Repository navigation
Split the Over-Length Comment Sentences in the Local and Canonical Review Engines - #3607
Conversation
…view Engines Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
A recorded local strict-review pass covers head |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3607 +/- ##
========================================
Coverage 81.60% 81.60%
========================================
Files 26 26
Lines 9070 9070
========================================
Hits 7402 7402
Misses 1668 1668
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
Four unresolved findings remain active: unclear or ungrammatical wording in two comments or docstrings, a --help text that will print as a run-on line, and overly long docstring lines in several files.
4 open issues
What changed in this PR
This PR splits over-long comment, docstring, and help-text sentences in the local and canonical review engines and their tests. The goal is to get these files to read zero on the prose_lint.py --check sentence-length check. It is a comment-only change, so runtime behavior should not change. It is a small part of the work tracked in issue #3531, which asks how carriers should handle sentence-length hits on hub-verbatim text.
Changes:
- Splits long sentences in comments, docstrings, and the
--helpdescription ofscripts/local_review.pyandscripts/canonical_review.pyinto shorter sentences. - Makes the same split in the docstrings and comments of
tests/test_local_review.pyandtests/test_canonical_review.py. - Turns some inline lists into bullets, and makes the module docstring's list print inline in
--help.
| File | Description |
|---|---|
| tests/test_local_review.py | Splits long docstring and comment sentences in the local review test cases. |
| tests/test_canonical_review.py | Splits long docstring and comment sentences in the canonical review test cases. |
| scripts/local_review.py | Splits long sentences in the module docstring, helper comments, and CannotRun docstring. The module docstring is also the --help text. |
| scripts/canonical_review.py | Splits long sentences in the module docstring, constants, and helper comments. |
Review effort: Lite
|
A recorded local strict-review pass covers head |
There was a problem hiding this comment.
🟡 Changes recommended
One unresolved active finding remains: a nit-level over-long docstring first paragraph at tests/test_canonical_review.py line 93 that still needs rewrapping to match the other test files.
1 open issue
4 resolved since last review
Review effort: Lite
Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
There was a problem hiding this comment.
🔵 Needs a closer look
Two findings that passed the severity filter were omitted from the published review, including a misleading explanation of when a path sorts last in scripts/canonical_review.py, so a human reviewer needs to assess them before approval.
No open issues 🎉
1 resolved since last review
Review effort: Lite
Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
Round 3 headline named the canonical_review.py explanation of which paths sort last. Reworded in the new head to: 'In the ordinary case that is a path for which git failed. In a repository with no commits at all it is every path, since git exits 128 rather than answering.' Same meaning as the original sentence on develop. |
There was a problem hiding this comment.
🟡 Changes recommended
An unresolved finding remains in scripts/canonical_review.py at line 538: the sentence has an unclear referent, and line 540 runs to 120 columns against the 100-column limit in pyproject.toml, even though an earlier thread reply said the text was reworded.
1 open issue
Review effort: Lite
Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
There was a problem hiding this comment.
🔵 Needs a closer look
Two low-severity findings in the test files were omitted from the published review, so a human reviewer needs to assess them before the review can be treated as complete.
No open issues 🎉
1 resolved since last review
Review effort: Lite
|
A recorded local strict-review pass covers head |
|
A recorded local strict-review pass covers head |
There was a problem hiding this comment.
🔵 Needs a closer look
The published review omitted a finding in tests/test_canonical_review.py (a lead sentence that says two kinds of case but describes three, plus a line over 100 columns), so a human reviewer needs to assess these hidden findings before approval.
No open issues 🎉
1 resolved since last review
Review effort: Lite
|
Triage of the round-7 headline (tests/test_canonical_review.py). (1) 'Two kinds of case live here' followed by a third, smaller set is the original wording on develop, so it is pre-existing and outside this comment-length sweep. A follow-up could reword it. (2) The line over 100 columns is the quoted 'Run as' command in the module docstring. It is kept on one line on purpose, as on develop, so the command stays copy-pasteable. No change. |
Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
Round-7 headline fixed in eb0815b: the test module docstring now says 'Three kinds of case live here.', matching the three sets it describes. The quoted 'Run as' command stays on one line. A fresh opus pass over the new head found no drift. |
There was a problem hiding this comment.
🟢 Approval recommended
The change touches only comments, docstrings, and help text, with code and test assertions unchanged and the syntax trees matching develop once docstrings are blanked, so no active issues were found.
No open issues 🎉
Review effort: Lite
…tence-length a Default Check (#3619) Promotes the #3531 comment sweep and its default flip from `develop` to `main`. - [#3603](#3603) Moves the dispatch-refresh note out of the Docker clause in branching-and-release-model. - [#3606](#3606) Splits over-length comment sentences in pr_review and host_gate. - [#3607](#3607) Splits over-length comment sentences in the local and canonical review engines. - [#3608](#3608) Splits over-length comment sentences in build_dist, carry, handoff, and skills_install. - [#3609](#3609) Splits over-length comment sentences in the prose and repo gates. - [#3611](#3611) Splits over-length comment sentences in the spec scripts and workflows. - [#3612](#3612) Splits over-length comment sentences in the host install scripts. - [#3613](#3613) Splits over-length comment sentences in the host menu, bootstrap, and setup scripts. - [#3615](#3615) Splits over-length comment sentences in the agent-safety kit, repo config, and snippets. - [#3618](#3618) Makes `sentence-length` a default prose gate check. Closes #3531 Closes #3588 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Splits the over-length comment, docstring, and help-text sentences in
scripts/local_review.py,scripts/canonical_review.py,tests/test_local_review.py, andtests/test_canonical_review.py. The four files read zero onprose_lint.py --check sentence-length(183 hits before). Comment-only change: the syntax trees with docstrings blanked are identical todevelop.Part of #3531
Notes:
local_review.pyis the--helpdescription, which argparse reflows. Its new bullet lists therefore print inline. No test asserts on that text.Copies left for the comment sweep
None known.
scripts/README.mdalready reads zero and its wording was adopted where the sentence was the same.🤖 Generated with Claude Code