You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Split the Over-Length Comment Sentences in the Host Install Scripts - #3612
Splits the over-length comment sentences in the host install scripts (install-tools, install-agents, install-skills, setup-wsl) and two test docstrings. Only comment lines and the two test module docstrings change. The .sh and .ps1 parallel comments are split identically, and where a Markdown copy already read zero its wording was adopted. prose_lint --check sentence-length reads 208 before and 0 after on the nine files.
Verification: bash -n, shellcheck, shfmt -d clean on each .sh. Each .ps1 parses with zero errors and PSScriptAnalyzer (repo settings) reports 0. test_install_tools, test_install_agents, test_host_gate, test_cli_usage, test_skills_install, test_bootstrap, test_setup_github pass.
Copies left for the comment sweep
None found outside the slice. The sentences with Markdown copies (host-setup/windows/README.md, docs/host-setup.md) already read zero and were adopted.
A recorded local strict-review pass covers head d0322631f79b1605264c134edd4e30c696a8ae00, the content this pull request carries at that commit against develop, and it recorded 0 findings.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.60%. Comparing base (b38e084) to head (2088775). ⚠️ Report is 6 commits behind head on develop.
A recorded local strict-review pass covers head e2256ee33d56e692581d2849ba4f8faad1c313c6, the content this pull request carries at that commit against develop, and it recorded 0 findings.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The change still has active review issues: grammar errors in the version-resolution explanation and brittle comments that hard-code a condition count, each repeated in another location.
No open issues 🎉
2 previously missed issues
In code that hasn't changed since last review
Fix grammar in version-resolution explanation
host-setup/windows/install-tools.ps1:311
[P2] Fix the grammar in the version-resolution explanationand there no single version compares is not a grammatical clause, and the next sentence uses singular is with the plural subject Two products. Rewrite these lines so the multiple-version case remains clear.
This issue also appears on line 412 of the same file.
Remove the incidental condition count
host-setup/windows/install-tools.ps1:891
[P2] Remove the incidental condition count The comment style contract requires an enumeration to refer to its items rather than duplicate their size. Four conditions will become stale if this safety predicate changes, so describe the conditions without counting them.
This issue also appears on line 924 of the same file.
A recorded local strict-review pass covers head 20887759a79105e0cceb3dde4b6d7e9d8350f6c4, the content this pull request carries at that commit against develop, and it recorded 2 findings.
Answering the two previously missed items from the e2256ee round, both fixed on 2088775. "Fix grammar in version-resolution explanation": the clause now reads "no single version compares there" and the next sentence reads "Two products sharing an id are what ...", and the "Two ids share a version" sentence in the sibling block is fixed too. "Remove the incidental condition count": the "Four conditions" lead-in now reads "All the conditions below are required together, for these reasons:".
…tence-length a Default Check (#3619)
Promotes the #3531 comment sweep and its default flip from `develop` to
`main`.
- [#3603](#3603) Moves the
dispatch-refresh note out of the Docker clause in
branching-and-release-model.
- [#3606](#3606) Splits
over-length comment sentences in pr_review and host_gate.
- [#3607](#3607) Splits
over-length comment sentences in the local and canonical review engines.
- [#3608](#3608) Splits
over-length comment sentences in build_dist, carry, handoff, and
skills_install.
- [#3609](#3609) Splits
over-length comment sentences in the prose and repo gates.
- [#3611](#3611) Splits
over-length comment sentences in the spec scripts and workflows.
- [#3612](#3612) Splits
over-length comment sentences in the host install scripts.
- [#3613](#3613) Splits
over-length comment sentences in the host menu, bootstrap, and setup
scripts.
- [#3615](#3615) Splits
over-length comment sentences in the agent-safety kit, repo config, and
snippets.
- [#3618](#3618) Makes
`sentence-length` a default prose gate check.
Closes#3531Closes#3588
🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commentsPermits the comment lines the pull request adds or edits, which the prose gate otherwise refuses
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3531
Splits the over-length comment sentences in the host install scripts (
install-tools,install-agents,install-skills,setup-wsl) and two test docstrings. Only comment lines and the two test module docstrings change. The.shand.ps1parallel comments are split identically, and where a Markdown copy already read zero its wording was adopted.prose_lint --check sentence-lengthreads 208 before and 0 after on the nine files.Verification:
bash -n,shellcheck,shfmt -dclean on each.sh. Each.ps1parses with zero errors and PSScriptAnalyzer (repo settings) reports 0.test_install_tools,test_install_agents,test_host_gate,test_cli_usage,test_skills_install,test_bootstrap,test_setup_githubpass.Copies left for the comment sweep
None found outside the slice. The sentences with Markdown copies (
host-setup/windows/README.md,docs/host-setup.md) already read zero and were adopted.🤖 Generated with Claude Code