Repository navigation
Split the Over-Length Comment Sentences in the Host Menu, Bootstrap, and Setup Scripts - #3613
Conversation
…and Setup Scripts Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ripts Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
A recorded local strict-review pass covers head |
There was a problem hiding this comment.
🟡 Changes recommended
The change still contains an unresolved comment ambiguity that could invert the rationale for the console-encoding conversion.
1 open issue
What changed in this PR
This pull request splits over-length comments and Python docstrings across host menu, bootstrap, setup scripts, and related tests while preserving executable behavior and printed output.
Changes:
- Reflows long comments and docstrings into shorter sentences and bullet lists.
- Applies equivalent updates across Bash, PowerShell, and Python files.
- Improves sentence-length lint compliance without changing runtime logic.
Final review comments note comment-marker consistency in bootstrap.sh and upgrade-host.ps1, an ambiguous encoding reference in upgrade-host.ps1, and wording about the desired registration state in setup-github.sh.
| File | Description |
|---|---|
tests/test_setup_github.py |
Splits the test module docstring. |
tests/test_bootstrap.py |
Splits bootstrap test docstrings and explanatory comments. |
tests/host_capability.py |
Splits host capability docstrings. |
host-setup/windows/upgrade-host.ps1 |
Splits Windows upgrade comments. Final comments: [P2] encoding reference ambiguity (severity: nit, 4 votes) and [P2] prescribed comment-marker usage (severity: nit, 1 vote). |
host-setup/windows/setup-github.ps1 |
Splits Windows GitHub setup comments. |
host-setup/menu.sh |
Splits Bash menu and locking comments. |
host-setup/menu.ps1 |
Splits PowerShell menu and locking comments. |
host-setup/linux/upgrade-host.sh |
Splits Linux upgrade comments. |
host-setup/linux/setup-github.sh |
Splits Linux GitHub setup comments. Final comment: [P1] desired registration-state wording (severity: nit, 1 vote). |
host-setup/bootstrap.sh |
Splits Bash bootstrap comments. Final comment: [P2] prescribed comment-marker usage (severity: nit, 1 vote). |
host-setup/bootstrap.ps1 |
Splits PowerShell bootstrap comments. |
Review effort: Lite
Part of #3531 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3613 +/- ##
========================================
Coverage 81.60% 81.60%
========================================
Files 26 26
Lines 9070 9070
========================================
Hits 7402 7402
Misses 1668 1668
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
A recorded local strict-review pass covers head |
…tence-length a Default Check (#3619) Promotes the #3531 comment sweep and its default flip from `develop` to `main`. - [#3603](#3603) Moves the dispatch-refresh note out of the Docker clause in branching-and-release-model. - [#3606](#3606) Splits over-length comment sentences in pr_review and host_gate. - [#3607](#3607) Splits over-length comment sentences in the local and canonical review engines. - [#3608](#3608) Splits over-length comment sentences in build_dist, carry, handoff, and skills_install. - [#3609](#3609) Splits over-length comment sentences in the prose and repo gates. - [#3611](#3611) Splits over-length comment sentences in the spec scripts and workflows. - [#3612](#3612) Splits over-length comment sentences in the host install scripts. - [#3613](#3613) Splits over-length comment sentences in the host menu, bootstrap, and setup scripts. - [#3615](#3615) Splits over-length comment sentences in the agent-safety kit, repo config, and snippets. - [#3618](#3618) Makes `sentence-length` a default prose gate check. Closes #3531 Closes #3588 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Part of #3531
Splits the over-length comment and docstring sentences in the host menu, bootstrap, and setup scripts, in their paired
.ps1and.shforms and the three test files that read them. Only comment lines and Python docstrings change. An AST comparison of the three test files and a changed-line check of the scripts confirm no code or printed string moved.Verification
prose_lint.py --check sentence-lengthover the 11 files: 261 before, 0 after.bash -n,shfmt -d, andshellcheckclean on the touched.shfiles.setup-github.shkeeps its SC2119/SC2120 findings onkey_body, which are present atdeveloptoo..ps1files.tests/test_bootstrap.py(150 tests, 5 skipped) andtests/test_setup_github.py(40 tests): OK.opus. The first six each found meaning drift (mostly a joint reason left attached to only one half), fixed in the commits that follow. The seventh found none, and its pass is recorded against the head.Known borderline wording left
host-setup/windows/upgrade-host.ps1:200-201: "That setting would also corrupt..." can be misread as referring to WSL_UTF8 rather than the console encoding.Copies left for the comment sweep
host-setup/bootstrap.ps1(split here) and ininstall-agents.ps1,install-tools.ps1, andsetup-wsl.ps1(slice F1).upgrade-host.ps1has an unsplit copy nearsetup-wsl.ps1:121(slice F1).🤖 Generated with Claude Code