Skip to content

[Bugfix] bifacial.power_mismatch_deline incorrect total RMAD from rear guidance #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
echedey-ls wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −3
Open

[Bugfix] bifacial.power_mismatch_deline incorrect total RMAD from rear guidance #2930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3763d41
Fix docstring equations
echedey-ls Nov 1, 2026
5cee1df
Add whatsnew entry
echedey-ls Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/sphinx/source/whatsnew/v0.16.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ Bug fixes
is scalar (:issue:`2881`, :pull:`2882`)
* :py:func:`pvlib.scaling.wvm` no longer returns all NaNs when ``positions``
contains a single site (:issue:`2895`, :pull:`2896`)
* Fix :py:func:`pvlib.bifacial.power_mismatch_deline` docstring's incorrect derivation

@cwhanse cwhanse Nov 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this note to the Documentation section

of total RMAD from rear RMAD. (:issue:`2929`, :pull:`2930`)

Enhancements
~~~~~~~~~~~~
Expand Down
6 changes: 3 additions & 3 deletions pvlib/bifacial/loss_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ def power_mismatch_deline(

.. math::

RMAD(k \cdot X + c) = RMAD(X) \cdot k \frac{k \bar{X}}{k \bar{X} + c}
= RMAD(X) \cdot \frac{k}{1 + \frac{c}{k \bar{X}}}
RMAD(k \cdot X + c) = RMAD(X) \frac{k \bar{X}}{k \bar{X} + c}
= RMAD(X) \cdot \frac{1}{1 + \frac{c}{k \bar{X}}}

by similarity with equation (2) of [1]_:

Expand All @@ -128,7 +128,7 @@ def power_mismatch_deline(

.. math::

RMAD_{total} = RMAD_{rear} \frac{\phi_{Bifi}}
RMAD_{total} = RMAD_{rear} \frac{1}
{1 + \frac{G_{front}}{\phi_{Bifi} \bar{G}_{rear}}}

See Also
Expand Down
Loading