Repository navigation
Preserve fractional timedelta seconds until formatting - #1401
Merged
akx merged 2 commits intoOct 26, 2026
Merged
Conversation
akx
requested changes
Oct 26, 2026
akx
enabled auto-merge (squash)
October 26, 2026 05:16
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1401 +/- ##
==========================================
+ Coverage 93.37% 93.48% +0.11%
==========================================
Files 27 27
Lines 4922 4930 +8
==========================================
+ Hits 4596 4609 +13
+ Misses 326 321 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1400.
Keep
timedeltafractional seconds through the existing formatting logic by usingtotal_seconds(). This is independent of the compound-unit change in #1399; this branch starts from unchanged upstream and contains no changes from that PR.Before/after
Unchanged upstream:
e2a17919f0eb988bfea2883b00793ca4d5d37c4f.Previously,
timedelta.days * 86400 + timedelta.secondsdrops microseconds and floors negative durations:Retaining the full signed duration lets the existing rounding, threshold and minimum-unit logic handle both signs consistently, without introducing a second rounding policy.
The final regression/control matrix produces sixteen failures and twenty-eight passes against unchanged production code. It checks both signs, direction on/off, fractional rounding boundaries, the minute threshold, zero, integral durations and the maximum whole-second positive timedelta.
Verification
CLDR 48.2 data was imported using the repository's download/import script and checksum validation. Local verification is Linux-only and does not claim every supported runtime or hosted CI passed.
Assistance
Investigated, implemented and tested with AI assistance. No personal account-owner review or provenance attestation is asserted.