Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #1402 by keeping star width/precision arguments distinct from decimal conversions during Python-format compatibility checks. The original argument-count fix remains intact.
%d,%i, and%uaccept floating-point values, whereas*requires integers. On current master (9a3ef477), this incompatible translation is accepted:Use a separate
*category and retain only the safe direction from a star argument to a decimal conversion. Ordinary conversion compatibility and named-placeholder behavior are unchanged. No new conversion families are made compatible.Tests
git diff --checkpass.Prepared with AI assistance, including independent review and actually executed synthetic tests. Hosted CI and other Python/platform combinations have not been run by this contribution; no maintainer approval is asserted.