Repository navigation
Conversation
…andling (35 tests) Add logic to make the 'distro' package importable without installation by checking specific directories.
…andling (35 tests)
…andling (35 tests)
…andling (35 tests)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream is built around per-distribution resource folders, so there's no compact fixture-driven coverage of the parsing rules themselves — quoting, comments, codename derivation, id normalisation, the distro-release file-name rule, the lsb fallback and the best-version algorithm. This adds 35 tests in three new files under tests/, every instance built from a temporary file (or a temporary root dir / fake lsb_release command), so no test depends on the host distribution. No production code changed. Quirks are pinned as-is with comments — a distro-release file's id comes from its file name, name(pretty=True) without PRETTY_NAME can produce a leading space, and version(best=True) picks the most-dotted candidate.
Checked locally: new files pass (35 passed), upstream suite still green (281 passed).