Skip to content

intcomma: expand floats whose repr uses scientific notation #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mayur-dhavan wants to merge 2 commits into from
+15 −0
Closed

intcomma: expand floats whose repr uses scientific notation #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15c1b2e
Keep intcomma floats out of scientific notation
mayur-dhavan Oct 25, 2026
2e55e12
Add intcomma regression tests for scientific-notation floats
mayur-dhavan Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/humanize/number.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
__lazy_modules__ = {"bisect"}

import bisect
from decimal import Decimal

from .i18n import _gettext as _
from .i18n import _gettext_noop as N_
Expand Down Expand Up @@ -198,6 +199,12 @@ def intcomma(value: NumberOrString, ndigits: int | None = None) -> str:
result = f"{value:,.{ndigits}f}"
else:
result = f"{value:,}"
if isinstance(value, float) and ("e" in result or "E" in result):
# repr-style float formatting switches to scientific notation
# (>= 1e16, < 1e-4); expand it so digits are still grouped.
result = format(Decimal(repr(value)), ",f")
if value.is_integer():
result += ".0"
if thousands_sep != "," or decimal_sep != ".":
result = result.translate(str.maketrans(",.", thousands_sep + decimal_sep))
return result
Expand Down
8 changes: 8 additions & 0 deletions tests/test_number.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,14 @@ def test_ordinal(test_input: str, expected: str) -> None:
([-math.inf], "-Inf"),
(["nan"], "NaN"),
(["-inf"], "-Inf"),
# Floats whose repr uses scientific notation stay expanded (issue #431)
([1e16], "10,000,000,000,000,000.0"),
([1.5e20], "150,000,000,000,000,000,000.0"),
([-1e16], "-10,000,000,000,000,000.0"),
([1e16, 0], "10,000,000,000,000,000"),
([0.00001], "0.00001"),
([1.23e-5], "0.0000123"),
([1234.5e15], "1,234,500,000,000,000,000.0"),
],
)
def test_intcomma(
Expand Down