Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default test run collects 878 tests but none of the 15 package doctest items. Pytest selects the settings in
pyproject.toml; the--doctest-modulesoption intox.iniis not merged into that configuration. The configuredtestpathsalso only includestests.Changes proposed in this pull request:
--doctest-modulesin the active pytest configuration.humanizetotestpathsand enable--pyargsso examples are collected from the same package used by the tests. This works for both editable installations and the installed distribution tested by tox, without mixing source-tree and installed modules.[pytest]section fromtox.iniso the settings have one source of truth.Validation on macOS with Python 3.14.5 and pytest 9.1.1:
python -m pytest -q— 878 passed.python -m pytest -q --benchmark-disable --color=no— 893 passed, including all 15 source doctest items.tox -e py -- --benchmark-disable --color=no— 893 passed against the installed distribution, with coverage enabled.natural_list()example with an incorrect string. The original configuration still passed all 878 tests; the updated configuration reported that doctest as the only failure (1 failed, 892 passed). The temporary edit was restored.tox -e py -- tests/test_number.py -k intcomma --benchmark-disable --color=no— 36 passed, 205 deselected; focused test selection still works.pyproject-fmt --check pyproject.toml,tox-ini-fmt --check tox.ini, andgit diff --checkpassed.Other platforms and Python versions have not been tested locally.
AI assistance: OpenAI Codex assisted with investigating the configuration, preparing the patch, and running the local checks.