You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Replace ctypes based Windows console calls in _pyrepl #150582
My preference is still that we ought to be actively migrating from ctypes to a proper native module for these. Performance and reliability will thank us.
I assume the things not yet in _winapi are fine to put in there?
Strictly speaking, yes, but if the module already has big chunks of Windows-specific functions that use those APIs, it's probably better (and likely easier) to just move the entire function into C.
I'm fine for a couple of higher-level functions to go into _winapi with comments that it should be moved to a REPL native module when one exists. Start their names with _pyrepl_... and there'll be no controversy.
Activity
chris-eibl commentedon Sep 11, 2026
@zooba I assume the things not yet in
_winapiare fine to put in there?zooba commentedon Sep 11, 2026
Strictly speaking, yes, but if the module already has big chunks of Windows-specific functions that use those APIs, it's probably better (and likely easier) to just move the entire function into C.
I'm fine for a couple of higher-level functions to go into
_winapiwith comments that it should be moved to a REPL native module when one exists. Start their names with_pyrepl_...and there'll be no controversy.