Repository navigation
gh-131498: Remove commented-out dead code in cases_generator/analyzer.py - #141168
Merged
Merged
Conversation
Remove the unused analyze_deferred_refs() function that was completely commented out. This function is not referenced anywhere in the codebase and removing it improves code cleanliness. Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
StanFromIreland
added
skip news
type-refactor
StanFromIreland
changed the title
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
All commit authors signed the Contributor License Agreement. |
Contributor
Author
|
@StanFromIreland can you please review? |
|
This PR is stale because it has been open for 30 days with no activity. |
|
Thanks @osamakader for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-160461 is a backport of this pull request to the 3.15 branch. |
ambv
pushed a commit
that referenced
this pull request
Oct 23, 2026
…nalyzer.py (GH-141168) (GH-160461) Remove the unused analyze_deferred_refs() function that was completely commented out. This function is not referenced anywhere in the codebase and removing it improves code cleanliness. (cherry picked from commit 1c75034) Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com> Co-authored-by: Osama Abdelkader <osama.abdelkader@gmail.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused analyze_deferred_refs() function that was completely commented out. This function is not referenced anywhere in the codebase and removing it improves code cleanliness.