Repository navigation
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
Co-authored-by: Muse Code (Meta Muse Spark)
Co-authored-by: Muse Code (Meta Muse Spark)
|
All commit authors signed the Contributor License Agreement. |
strchr() and (char) narrowing misclassified non-ASCII conversions: characters like U+0164 (low byte 'd') were passed through to the platform strftime, U+0080-U+00FF raised OverflowError, and the rest were echoed as mojibake. Only ASCII can name a conversion, so echo anything else back literally with the full code point, matching the pure-Python implementation. Add regression tests. Co-authored-by: Muse Code (Meta Muse Spark)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unifies the behavior of
datetime.strftimewhen encountering unsupported or invalid non-zero-padded specifiers across different platforms.Previously, the behavior for invalid specifiers was inconsistent:
Windows: Raised a
ValueErrormacOS/FreeBSD: Could return partial strings or stripped characters (e.g., returning
#instead of%-#).Linux: Echoes the specifier back as-is (e.g.,
%-#).The behavior is now unified to match Linux.
datetime.strftime#139088