Skip to content

gh-159394: Use current screen size in test_newterm - #159656

Closed
lpyu001 wants to merge 1 commit into
python:mainfrom
lpyu001:gh-159394
Closed

lpyu001 wants to merge 1 commit into
python:mainfrom
lpyu001:gh-159394

Conversation

@lpyu001

@lpyu001 lpyu001 commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

@lpyu001

lpyu001 commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

cc @serhiy-storchaka

@serhiy-storchaka

Copy link
Copy Markdown
Member

Thank you for the PR, @lpyu001. Unfortunately, comparing with curses.LINES and curses.COLS makes the check almost a tautology, since newterm() sets them from the same screen, and it does not fix SLKTests.test_init_reserves_a_line, which fails for the same reason. The size of the screen depends on the LINES and COLUMNS environment variables (see the comment in the issue), so #159665 sets them in these tests instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants