Repository navigation
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Author
|
"Benchmarks": Before: After |
aisk
reviewed
Oct 18, 2026
| getattr(module, "version") | ||
| self.assertEqual(cm.filename, __file__) | ||
|
|
||
| class TestImportTime(unittest.TestCase): |
Member
There was a problem hiding this comment.
The class name is a little bit misleading, it doesn't test the import time at all. Maybe we can put the test function in TestModule in this file.
Author
There was a problem hiding this comment.
This makes sense, adjusted and fixed the PEP8 issue
Both urllib imports are only used for prepare_input_source, normally not used when parsing or writing XML files. A real life example of the benefit of lazy loading is the "firewalld" daemon on Fedora/RHEL Linux systems where lazy loading urllib shaves off 3MB memory.
jelly
force-pushed
the
saxutils-lazy-load-urllib
branch
from
October 18, 2026 18:07
c7f16ed to
66c3450
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both urllib imports are only used for prepare_input_source, normally not used when parsing or writing XML files.
A real life example of the benefit of lazy loading is the "firewalld" daemon on Fedora/RHEL Linux systems where lazy loading urllib shaves off 3MB memory.
Alternatively I can just move the imports to
prepare_input_sourceif desired and drop the test case.