Skip to content

gh-159690: Fix TimedRotatingFileHandler stopping rollovers after a failed or skipped rollover - #159691

Closed
lazerg wants to merge 2 commits into
python:mainfrom
lazerg:fix-issue-159690
Closed

lazerg wants to merge 2 commits into
python:mainfrom
lazerg:fix-issue-159690

Conversation

@lazerg

@lazerg lazerg commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

doRollover() only updated rolloverAt on its last line, so an early return (backup name already exists, as happens at DST changes) or an exception after the rename left it in the past. Every later emit() then hit the same early return and the handler never rolled over again. Now rolloverAt is computed as soon as the backup name is known, so only that one rollover is affected.

@picnixz

picnixz commented Oct 19, 2026

Copy link
Copy Markdown
Member

I'm going to close this because the OP may have wanted to open a PR themselves. Please don't let any running agent snipe issues to create PRs automatically. Or at least, ask on the issue if the OP wants to make a PR.

@picnixz picnixz closed this Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants