Repository navigation
gh-159739: Fix crash in _PyTuple_Resize() with an invalid size - #159804
Merged
Merged
Conversation
gpshead
force-pushed
the
claude/elegant-faraday-p69m3r
branch
from
October 19, 2026 22:34
339d31a to
48e893e
Compare
|
All commit authors signed the Contributor License Agreement. |
Check that the items of a non-empty tuple are released when the reallocation in _PyTuple_Resize() fails.
_PyTuple_Resize() did not validate newsize for non-empty tuples. Raise SystemError for a negative size and MemoryError for a too-large size, like PyTuple_New() already does for the empty-tuple path.
gpshead
force-pushed
the
claude/elegant-faraday-p69m3r
branch
from
October 19, 2026 22:43
1afc2ec to
db04f57
Compare
gpshead
added
needs backport to 3.14
It relied on a huge allocation request failing, which is not portable: TSan aborts on it and it succeeds on wasm32 (WASI).
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-159976 is a backport of this pull request to the 3.15 branch. |
|
GH-159977 is a backport of this pull request to the 3.14 branch. |
gpshead
added a commit
that referenced
this pull request
Oct 21, 2026
…GH-159804) (#159976) gh-159739: Fix crash in _PyTuple_Resize() with an invalid size (GH-159804) _PyTuple_Resize() did not validate newsize for non-empty tuples. Raise SystemError for a negative size and MemoryError for a too-large size, like PyTuple_New() already does for the empty-tuple path. (cherry picked from commit c360884) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
gpshead
added a commit
that referenced
this pull request
Oct 21, 2026
…GH-159804) (#159977) gh-159739: Fix crash in _PyTuple_Resize() with an invalid size (GH-159804) _PyTuple_Resize() did not validate newsize for non-empty tuples. Raise SystemError for a negative size and MemoryError for a too-large size, like PyTuple_New() already does for the empty-tuple path. (cherry picked from commit c360884) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a crash in
_PyTuple_Resizewhen resizing a non-empty tuple to anegative or too large size. It now raises
SystemErrororMemoryErrorrespectively.