Repository navigation
[3.14] gh-159759: Fix libpython.static in PEP 739 build-details.json (GH-159766) - #159824
Merged
Merged
Conversation
…ythonGH-159766) When a shared library is also built, point `libpython.static` at `LIBPL`, the only place `make install` puts the static library, and don't list it for framework builds, which don't install one. Static-only builds keep the existing `LIBDIR` value, which is installed in that configuration. (cherry picked from commit e41b38b) Co-authored-by: Itamar Oren <itamarost@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a shared library is also built, point
libpython.staticatLIBPL,the only place
make installputs the static library, and don't list it forframework builds, which don't install one. Static-only builds keep the
existing
LIBDIRvalue, which is installed in that configuration.(cherry picked from commit e41b38b)
Co-authored-by: Itamar Oren itamarost@gmail.com
build-details.jsonpoint at nonexistentlibpython.staticfor--enable-sharedand framework builds #159759