Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159792.
The accelerated warnings implementation used the supplied per-module registry for the
"once"action. As a result, the same warning was emitted again from another module, contrary to the documented behavior and the pure-Python implementation.Always use the global once registry for this action. Add a shared regression that emits the same warning on different lines in two modules; it fails with the unmodified C implementation and passes with this fix and with the Python implementation.
Validation on Linux x86-64 debug builds:
test_warningsandtest_loggingpassed in GIL and free-threaded builds (494 test cases in each; expected skips)../python -X context_aware_warnings=1 -m test test_warningspassed../python -m test -R 3:3 -m test_once_across_modules test_warningspassed with no reference leaks.patchcheck, andgit diff --checkpassed.