Repository navigation
gh-138641: Ignore set_trace() when we are already in pdb - #159918
Merged
Merged
Conversation
Member
Author
|
Hi @iritkatriel , could you take a look at this? This also happens to fix #142964 . |
iritkatriel
approved these changes
Oct 20, 2026
gaogaotiantian
added
needs backport to 3.14
|
Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-159970 is a backport of this pull request to the 3.15 branch. |
|
GH-159971 is a backport of this pull request to the 3.14 branch. |
gaogaotiantian
added a commit
that referenced
this pull request
Oct 21, 2026
gaogaotiantian
added a commit
that referenced
this pull request
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we can't really trigger tracing functions when we are already tracing (unless we explicitly do it via
sys.call_tracing), runningbreakpoint()/set_trace()in pdb does not make much sense. We can probably make it enter a recursive debugger in the future, but for now, ignoring it should be the simple way to go.Notice that this is not really a breaking change as it does not work before. The nested debugger will clear the outer debugger's states and it's still the outer debugger that got triggered.
pdbcommands may try to access non-existing frames #138641