Repository navigation
gh-159998: Fix libpython.dynamic in build-details.json for framework builds - #160005
Merged
Merged
Conversation
…ework builds In framework builds, LDLIBRARY is the framework library's path relative to PYTHONFRAMEWORKPREFIX (e.g. Python.framework/Versions/3.X/Python), so joining it with LIBDIR named a file that doesn't exist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
itamaro
added
build
brettcannon
approved these changes
Oct 21, 2026
brettcannon
left a comment
brettcannon
left a comment
Member
There was a problem hiding this comment.
Usual caveat that I don't use a Mac, so I can't attest to the semantics.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
itamaro
enabled auto-merge (squash)
October 21, 2026 21:54
ambv
approved these changes
Oct 21, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks @itamaro for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-160145 is a backport of this pull request to the 3.15 branch. |
|
GH-160146 is a backport of this pull request to the 3.14 branch. |
ambv
pushed a commit
that referenced
this pull request
Oct 21, 2026
…ramework builds (GH-160005) (#160145) In framework builds, `libpython.dynamic` now joins `PYTHONFRAMEWORKPREFIX` with `LDLIBRARY` instead of `LIBDIR` with `LDLIBRARY`, so it points at the framework library that is actually installed. Other builds are unchanged. (cherry picked from commit 13c758d) Co-authored-by: Itamar Oren <itamarost@gmail.com>
ambv
pushed a commit
that referenced
this pull request
Oct 21, 2026
…ramework builds (GH-160005) (#160146) In framework builds, `libpython.dynamic` now joins `PYTHONFRAMEWORKPREFIX` with `LDLIBRARY` instead of `LIBDIR` with `LDLIBRARY`, so it points at the framework library that is actually installed. Other builds are unchanged. (cherry picked from commit 13c758d) Co-authored-by: Itamar Oren <itamarost@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In framework builds,
libpython.dynamicnow joinsPYTHONFRAMEWORKPREFIXwithLDLIBRARYinstead ofLIBDIRwithLDLIBRARY, so it points at the framework library that is actually installed. Other builds are unchanged.Written with assistance from Claude Code Opus 5.5
build-details.jsonpointslibpython.dynamicat a nonexistent path in framework builds #159998