Repository navigation
Conversation
make_paths_relative() first made base_prefix relative to the config file's directory and then made the other paths relative to that relative base_prefix, instead of the absolute one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
itamaro
added
build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_paths_relative()now keeps the absolutebase_prefixfor computing the other paths, and only the storedbase_prefixis made relative to the config file's directory. This is the same fix python-build-standalone carries inpatch-python-relative-build-details.patch(by @geofft). That patch also changes the Makefile to generate relative paths by default; this PR leaves the Makefile alone.Written with assistance from Claude Code Opus 5.5
generate-build-details.py --relative-paths --config-file-pathwrites wrong paths #160004